Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course overview bug fixes #271

Merged
merged 23 commits into from
Feb 4, 2024
Merged

Course overview bug fixes #271

merged 23 commits into from
Feb 4, 2024

Conversation

GravityDarkLab
Copy link
Member

No description provided.

@GravityDarkLab GravityDarkLab self-assigned this Feb 2, 2024
@GravityDarkLab GravityDarkLab added the bug Something isn't working label Feb 2, 2024
@GravityDarkLab GravityDarkLab linked an issue Feb 3, 2024 that may be closed by this pull request
@GravityDarkLab GravityDarkLab marked this pull request as ready for review February 4, 2024 11:38
ahmetsenturk
ahmetsenturk previously approved these changes Feb 4, 2024
Copy link
Collaborator

@ahmetsenturk ahmetsenturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Achraf 👍

  • I like the pin icon indicating a lecture is pinned already.
  • The colors are also back with TUM IDs.
  • Bear in mind that I couldn't test the download cards

Also a note for future PRs:

  • Please don't mix formatting with feature branches. It makes it difficult for the reviewer to pay attention to real changes 😉

@GravityDarkLab GravityDarkLab merged commit 3ac7f8c into dev Feb 4, 2024
1 check passed
@GravityDarkLab GravityDarkLab deleted the course-overview-bug-fixes branch February 4, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants